Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19014] Fix Github Windows CI #3616

Merged

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jun 24, 2023

Description

This PR:

  1. Fixes an AttributeError exception in Windows DS secure tests
  2. Adds security to github windows CI runs

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.11.0 milestone Jun 24, 2023
EduPonz and others added 5 commits June 25, 2023 06:43
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the hotfix/multiple_secure_ds_pubsub_secure_crypto_communication branch 21 times, most recently from 273d6c7 to a983b97 Compare June 27, 2023 15:02
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the hotfix/multiple_secure_ds_pubsub_secure_crypto_communication branch from a983b97 to aca96a2 Compare June 27, 2023 15:09
@EduPonz EduPonz merged commit 802f224 into master Jun 28, 2023
7 of 8 checks passed
@EduPonz EduPonz deleted the hotfix/multiple_secure_ds_pubsub_secure_crypto_communication branch June 28, 2023 12:46
@EduPonz
Copy link
Author

EduPonz commented Dec 1, 2023

@Mergifyio backport 2.10.x

Copy link
Contributor

mergify bot commented Dec 1, 2023

backport 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 1, 2023
* Refs #19014: Fix windows exception

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Run github windows CI with security

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Fix secure_ds_pubsub_secure_crypto_communication.py

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Exit with 0 it EX_OK does not exist

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: adding softhsm2-util to path

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

* Refs #19014: Correctly propagate path between steps

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Check softhsm with --help option

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014. Add SOFTHSM2_CONF to fix softhsm2 operation

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

---------

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Co-authored-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 802f224)
EduPonz added a commit that referenced this pull request Dec 2, 2023
* Refs #19014: Fix windows exception

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Run github windows CI with security

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Fix secure_ds_pubsub_secure_crypto_communication.py

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Exit with 0 it EX_OK does not exist

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: adding softhsm2-util to path

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

* Refs #19014: Correctly propagate path between steps

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Check softhsm with --help option

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014. Add SOFTHSM2_CONF to fix softhsm2 operation

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

---------

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Co-authored-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 802f224)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Jan 10, 2024
* Refs #19014: Fix windows exception

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Run github windows CI with security

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Fix secure_ds_pubsub_secure_crypto_communication.py

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Exit with 0 it EX_OK does not exist

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: adding softhsm2-util to path

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

* Refs #19014: Correctly propagate path between steps

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014: Check softhsm with --help option

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19014. Add SOFTHSM2_CONF to fix softhsm2 operation

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

---------

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Co-authored-by: Miguel Barro <miguelbarro@eprosima.com>
EduPonz added a commit that referenced this pull request Jan 10, 2024
* Refs #19014: Fix windows exception



* Refs #19014: Run github windows CI with security



* Refs #19014: Fix secure_ds_pubsub_secure_crypto_communication.py



* Refs #19014: Exit with 0 it EX_OK does not exist



* Refs #19014: adding softhsm2-util to path



* Refs #19014: Correctly propagate path between steps



* Refs #19014: Check softhsm with --help option



* Refs #19014. Add SOFTHSM2_CONF to fix softhsm2 operation



---------

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Barro <miguelbarro@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants